ci: continue execution after job skipped#5345
Open
ivaylo-mi wants to merge 1 commit intoweaveworks:mainfrom
Open
ci: continue execution after job skipped#5345ivaylo-mi wants to merge 1 commit intoweaveworks:mainfrom
ivaylo-mi wants to merge 1 commit intoweaveworks:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
What changed?
The jobs in the CI workflow are updated to be executed when the "Validate PR title" one is skipped.
Why was this change made?
To execute the complete workflow after release.
How was this change implemented?
The !failure() condition is added to all jobs after the "Validate PR title". There are other ways to implement (as example checking for skipped or success), this one is chosen as more compact.
In addition the path of the published helm chart is changed by adding "/charts/" to it, together with fixing the siging (docker login is added for this).
How did you validate the change?
Manually ran the workflow (with and without run_release_jobs set to true)
Release notes
No
Documentation Changes
No