Adjust generic for NestedDataTypeConfig when ObjectDataType
#233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
4 tasks
pacyL2K19
reviewed
Nov 21, 2024
| dataType: ObjectDataType; | ||
| /** only for object types */ | ||
| nestedProperties?: NestedPropertyConfigCreate<T, ObjectDataType>[]; | ||
| nestedProperties?: NestedPropertyCreate<T>[]; |
There was a problem hiding this comment.
This fix may work @tsmith023
Just confirming in a short period
|
Great to see you again! Thanks for the contribution. |
pacyL2K19
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the generic of the
nestedPropertiesfield inNestedDataTypeConfigwhendataTypehas the typeObjectDataTypeso that there are no compiler errors whenstrict: falsewhen defining thenestedPropertiesfield of a property type withobjectorobject[]data typeIn short, by making use of
NestedPropertyConfigCreate, the same issue ofstrict: falsenot resolving the conditional typeT extends undefined ? ... : ...is encountered. With this change, we avoid that and so remove the bug