Use type of includeVector to narrow vectors generic in returns
#265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
|
Great to see you again! Thanks for the contribution. |
…/weaviate/typescript-client into 1.29/map-include-vector-to-return-vector-generic
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets | 0 0 0 0 |
View in Orca |
tsmith023
added a commit
that referenced
this pull request
Jul 15, 2025
* Update protos to use latest available on `main` * Hook up new grpc backend, fix aggregate.hybrid bug, update CI images * Fix npm run docs script * Remove redundant file * Fix unit tests * Rollback to 1.28.2 in CI due to testcontainers issue * Skip test in <1.26 due to missing maxVectorDistance * Update swagger stubs and impl accordingly * Replace testcontainers rbac tests with compose stack * Add implementation for aggregate groupby * Change `as any` to `as Record<string, any>` for a narrower condition * Several refactorings: - Split `roles` with `users` - make `actions` an array inside `permissions` - rename several methods to be aligned with py client in a non-BC way - only run roles/users tests for `>1.29` due to no BC * Add implementation supporting multi-vectors (no tests yet) * Respond to review comments * Fix type errors, add build to pre-commit * Making sweeping changes: - Introduce `V` generic for collections allowing users to define types for their multiple vectors - Add support for creating multivector collections - Add BC support for querying multivector collections - Add yielding to de/ser logic of multivectors to avoid expensive blocking CPU loops - Update CI image * Refactor RBAC to use new CRUD roles actions, update CI * Invert parsing of vector type logic to achieve BC * Use type of `includeVector` to narrow vectors generic in returns (#265) * Add alpha tag to pkgs published from this branch * 3.6.0-alpha.0 * Remove `--tag alpha` from CI publish step * Add support for configuring muvera encoding with multivectors * Add `configure.multiVectors`, allow `quantizer` and `encoding` in vectorizer/multiVectors factories * Update new tests to use new API surface * Fix `multiVectors.selfProvided` behaviour * Rename `vectorizer` to `vectors`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.