Skip to content

Conversation

@bevzzz
Copy link
Collaborator

@bevzzz bevzzz commented Apr 15, 2025

What is changed?

This PR adds optional includeLastUsedTime parameter to users.db.byName and users.db.listAll methods, which controls if the last login time will be retrieved for the users.

Additionally, UserDB model has 2 new fields:

  • createdAt: returned for all users (provided server is v1.30.1 and above)
  • apiKeyFirstLetters: returned whenever request is made by the cluster admin (intended to be displayed in the WCS Console)

Updated openapi.ts schema spec.

TODO

  • Run tests with v1.30.1

@bevzzz bevzzz requested a review from tsmith023 April 15, 2025 19:19
Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 1   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca
🛡️ The following SAST misconfigurations have been detected
NAME FILE
medium Potential ReDoS Vulnerability from Non-Literal RegExp Usage .../integration.test.ts View in code

@bevzzz bevzzz marked this pull request as ready for review April 17, 2025 11:03
@bevzzz bevzzz requested a review from a team as a code owner April 17, 2025 13:33
@bevzzz bevzzz force-pushed the feat/new-user-fields branch 2 times, most recently from f8b66be to cefa0bc Compare April 17, 2025 14:39
@bevzzz bevzzz force-pushed the feat/new-user-fields branch from cefa0bc to 9df0dca Compare May 6, 2025 11:10
@bevzzz bevzzz requested a review from tsmith023 May 6, 2025 11:11
@bevzzz bevzzz merged commit 173b0b8 into main May 6, 2025
16 checks passed
@bevzzz bevzzz deleted the feat/new-user-fields branch May 6, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants