-
Notifications
You must be signed in to change notification settings - Fork 30
Fix breaking changes from v3.7.0 release #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
02c9c62
wip: exclude 'vectorizeCollectionName' from arguments
bevzzz 84fb1f3
Revert "wip: exclude 'vectorizeCollectionName' from arguments"
bevzzz f00044e
refactor: shade 'vectorizeCollectionName' parameter in 'configure.vec…
bevzzz a5d9256
fix: shade configure.vectors and hide vectorizeCollectionName parameter
bevzzz c650896
test: update expectations
bevzzz fb05150
feat: add selfProvided as an alias to none
bevzzz dabfd0e
test: ignore order of array elements
bevzzz 5a5819e
chore: rename modelId -> model for -Google vectors
bevzzz 339dba7
feat: rename model -> modelId for Google vectorizers
bevzzz ca16e3d
chore: add comments
bevzzz 9f2a536
ci(temp): tag alpha release
bevzzz bbac850
refactor: do not export legacyVectors directly
bevzzz 98aefb1
feat: support multi2vec-nvidia vectorizer
bevzzz 39c6572
Revert "ci(temp): tag alpha release"
bevzzz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -246,7 +246,14 @@ export default { | |
| console.warn('The `generative-palm` module is deprecated. Use `generative-google` instead.'); | ||
| return { | ||
| name: 'generative-palm', | ||
| config, | ||
| // Do not populate config key if config === undefined. | ||
| config: config | ||
| ? { | ||
| ...config, | ||
| // Only create modelId key if either config.model or config.modelId are defined. | ||
| ...(config?.modelId || config?.model ? { modelId: config?.model ?? config?.model } : undefined), | ||
| } | ||
| : undefined, | ||
| }; | ||
| }, | ||
| /** | ||
|
|
@@ -262,7 +269,14 @@ export default { | |
| ): ModuleConfig<'generative-google', GenerativeGoogleConfig | undefined> => { | ||
| return { | ||
| name: 'generative-google', | ||
| config, | ||
| // Do not populate config key if config === undefined. | ||
| config: config | ||
| ? { | ||
| ...config, | ||
| // Only create modelId key if either config.model or config.modelId are defined. | ||
| ...(config?.modelId || config?.model ? { modelId: config?.model ?? config?.model } : undefined), | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This syntax is fairly dense. My intention was to copy the model name into the |
||
| } | ||
| : undefined, | ||
| }; | ||
| }, | ||
| /** | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.