Support using alias to ingest data. #133
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
There were few checks verifying that the collection would exist before ingesting/updating/deleting data. However, if an alias exists it is not found when listing collections. Therefore, a better check had to be included, as well as some code to use the collection with the alias right before the data operation is about to take place (it's not possible to do collection modifications or getting config using an alias)
jfrancoa
force-pushed
the
jose/fix-collection-alias-data-creation
branch
from
d806522 to
63ee163
Compare
|
Great to see you again! Thanks for the contribution. |
Now it's possible to query schema using the alias so we don't need to keep the alias and collection referenced to do either one operation or the other. Also, add support for the override_alias when restoring the backup.
jfrancoa
force-pushed
the
jose/fix-collection-alias-data-creation
branch
from
091baf2 to
8a1d3d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were few checks verifying that the collection would exist before ingesting/updating/deleting data. However, if an alias exists it is not found when listing collections. Therefore, a better check had to be included, as well as some code to use the collection with the alias right before the data operation is about to take place (it's not possible to do collection modifications or getting config using an alias)