Fix replication_deletion_strategy overriding server default#160
Merged
Fix replication_deletion_strategy overriding server default#160
Conversation
The CLI hardcoded "no_automated_resolution" as the default for replication_deletion_strategy, which always overrode the Weaviate server default. Now defaults to None so the server-side default (time_based_resolution) is used when the user doesn't explicitly set the flag. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Secrets |  0  0  0  0 |
View in Orca |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CreateCollectionDefaults.replication_deletion_strategyfrom"no_automated_resolution"toNone--replication_deletion_strategy, the CLI now defers to the Weaviate server default (time_based_resolution) instead of always sendingno_automated_resolutioncreate collectionparameters — no other parameter has this issue (flags are explicit opt-in, numeric/string defaults are guarded by conditionals or match server defaults)Test plan
create collectionwithout--replication_deletion_strategyuses server defaultcreate collection --replication_deletion_strategy delete_on_conflictstill works🤖 Generated with Claude Code