Conversation
Introduce collections.Handle with Data and Query namespaces
MockTransport can now be created with stubs that describe different request-response pairs by parameterizing them with [any, any]. The Do method relies on reflection for detecting such cases and treats them differently both when comparing the request values and assigning responses back to dest.
…HEAD-like requests
- NewClient - NewLocal - NewWeaviateCloud
We use map[string]Result in the public API to make it easy to lookup individual results. Internally we always want to iterate over all of the values, and working with slices is easier
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Secrets | View in Orca |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the Aggregate namespace to the collection handle with 2 aggregation types: over all and near vector. I decided to add both at once to explore the differences in the API (one has a search filter, the other one doesn't) and see where their APIs have touching points.
As usual, a large part of the diff is dedicated to tests. Since NearVector and OverAll share the same underlying implementation (see
aggregate.aggregatefunction), the tests focus on the OverAll query and only verify thatNearVectorparameter is set ifAggregate.NearVector()is called.The syntax is something like this: