Skip to content

Dev/1.28 #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dirkkul merged 140 commits into from
Dec 12, 2024
Merged

Dev/1.28 #1454

dirkkul merged 140 commits into from
Dec 12, 2024

Conversation

@tsmith023
Copy link
Collaborator

@tsmith023 tsmith023 commented Dec 4, 2024

No description provided.

tsmith023 and others added 30 commits November 4, 2024 17:02
@tsmith023
Add initial skeleton of API structure with pseudo-code test usage
f206682
@tsmith023
Add implementation for RBAC REST requests and initial testing suite
ff8e7e6
@tsmith023
Remove rbac compose file for now
f6c8a3e
@tsmith023
Rename types.py to models.py
9608586
@tsmith023
Fix import
7ac4565
@tsmith023
Actually skip nonfunctioning test
3ffedb1
@tsmith023
Remove scratch test file
c276c85
@tsmith023
Add back CI test that fails due to known issue
6998a98
@tsmith023
Reallign actions with new server impl
3f7ab4e
@tsmith023
Update CI to use functional image
d239bfe
@tsmith023
Merge branch 'main' of https://github.com/weaviate/weaviate-python-cl…
0af7fba 
…ient into 1.28/add-support-for-rbac
@tsmith023
Change to correct ports for CI
ed526c4
@tsmith023
Update CI images
37ab8fc
@tsmith023
Skip rbac test if not supported
2e9b229
@dirkkul
Adapt role names plural
d99b520
@tsmith023
Refactor connection removing level from internal Permissions object
abf3d8e
@tsmith023
Merge branch '1.28/add-support-for-rbac' of https://github.com/weavia…
b822e94 
…te/weaviate-python-client into rbac/reallign-with-new-server-api
@tsmith023
Use / instead of ;; in collection-tenant resources string
51de75b
@dirkkul
Merge pull request #1397 from weaviate/rbac/reallign-with-new-server-api
aa25b17 
Refactor connection removing `level` from internal Permissions object
@dirkkul
Adapt to simplified rbac permissions
60d6829
@dirkkul
Merge pull request #1398 from weaviate/adapt_to_simplified_permissions
0b90206 
Adapt to simplified rbac permissions
@dirkkul
Adapt to changes in schema resources
002ea00
@dirkkul
Merge pull request #1405 from weaviate/adapt_schema_changes
8a7b873 
Adapt to changes in schema resources
@dirkkul
Move *_collection actions to Collection
16814ca
@dirkkul
Really fix test
42dc0a9
@dirkkul
Update CI image
92fed33
@dirkkul
really really fix test
ce286d6
@tsmith023
Refactor actions for latest domains in backend, add further tests, up…
506284f 
…date CI image
@tsmith023
Merge pull request #1411 from weaviate/rbac_adapt_actions
69b24bc 
Move *_collection actions to Collection
@tsmith023
Remove rbac/model.conf file from CI
f3efe5f
tsmith023 and others added 26 commits December 5, 2024 14:58
@tsmith023
Fix failing tests
bbed519
@tsmith023
Merge pull request #1459 from weaviate/1.28/respond-to-rbac-surface-f…
d3160f7 
…eedback

Rename `role -> role_name`, add `InsufficientPermissionsError`
@tsmith023
Change inheritance of new exception to maintain BC
d8c832a
@tsmith023
Fix typing issues
ca95702
@tsmith023
Merge pull request #1460 from weaviate/1.28/refactor-insufficient-per…
75c9d82 
…missions-inheritance

Change inheritance of new exception to maintain BC
@tsmith023
Rename methods in .roles for better UX
e4b47a4
@tsmith023
Fix incorrect naming of arg in assigned_users
c785520
@tsmith023
Merge pull request #1463 from weaviate/rbac/refactor-api-methods
512f9af 
Rename methods in .roles for better UX
@tsmith023
Check status code of gRPC message to throw insuf perms err
2871ad9
@tsmith023
Fix incorrect arg name in revoke method
3763f29
@tsmith023
Replace "PERMISSION_DENIED" with const
532112f
@tsmith023
Merge pull request #1464 from weaviate/1.28/raise-insufficient-perms-…
d6645b6 
…err-in-grpc

Check status code of gRPC message to throw insuf perms err
@jfrancoa
Add exists to sync.pyi
e19fd0f
@dirkkul
Merge pull request #1467 from weaviate/jose/add-exists-sync
92d3eeb 
Add exists to sync.pyi
@dirkkul
Rename assign/revoke
066d4f4
@dirkkul
Merge pull request #1468 from weaviate/rbac_delete_revoke
79643ef 
Rename assign/revoke
@tsmith023 @jfrancoa
Add .has_permission method and test of its usage wth server image
efc57c0
@tsmith023
Refactor logic for new endpoints implementation
8a0cd9f
@tsmith023
Merge pull request #1457 from weaviate/1.28/support-has-permissions-e…
31ceb82 
…ndpoint

Add `.has_permission` method and test of its usage wth server image
@tsmith023
Merge branch 'dev/1.28' of https://github.com/weaviate/weaviate-pytho…
69319cd 
…n-client into rbac/refactor-add-remove-permissions
@tsmith023
Add test of remove permissions logic
957f932
@tsmith023
Merge pull request #1469 from weaviate/rbac/refactor-add-remove-permi…
d987ac8 
…ssions

Refactor logic for new endpoints implementation
@dirkkul
Remove manage_collection/data from factories
47ec90a
@dirkkul
Rename role names
0bcf78a
@dirkkul
Merge pull request #1470 from weaviate/remove_manage
9281646 
Remove manage_collection/data from factories
@dirkkul
Merge branch 'main' into dev/1.28
e11b2f4
@dirkkul dirkkul marked this pull request as ready for review December 12, 2024 06:41
@dirkkul dirkkul requested a review from a team as a code owner December 12, 2024 06:41
@dirkkul dirkkul merged commit 5cf1640 into main Dec 12, 2024
41 checks passed
@dirkkul dirkkul deleted the dev/1.28 branch December 12, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orca-security-eu orca-security-eu[bot] orca-security-eu[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tsmith023 @weaviate-git-bot @codecov-commenter @dirkkul @moogacs @jfrancoa