Skip to content

Conversation

@databyjp
Copy link
Collaborator

@databyjp databyjp commented Nov 26, 2025

Model provider updates

  • Add new aws_sagemaker & aws_bedrock factory methods where appropriate for t2v & generative (only bedrock for multi2vec)
  • Add google_vertex / google_gemini factory methods where appropriate
    • multi2vec_google seems to be vertex only; have left it as-is for now
  • Rename google_aistudio methods to google_gemini where appropriate
  • Update cohere & openai vectorizer parameters (see for reference: openai and cohere db code)
    • Remove returnLikelihoods param from Cohere config dict - doesn't appear implemented server side
  • Add missing params to AWS, XAI and AWS (Sagemaker) generative configs

Note - some further updates needed when server-side proto updated to match (see TODO notes)

Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2025

Codecov Report

❌ Patch coverage is 84.93151% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.55%. Comparing base (dac5bd7) to head (5d6aa26).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
weaviate/collections/classes/config.py 88.57% 4 Missing ⚠️
weaviate/collections/classes/generative.py 77.77% 4 Missing ⚠️
weaviate/collections/classes/config_vectors.py 84.21% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1882      +/-   ##
==========================================
- Coverage   86.56%   86.55%   -0.01%     
==========================================
  Files         273      273              
  Lines       19777    19840      +63     
==========================================
+ Hits        17120    17173      +53     
- Misses       2657     2667      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@databyjp databyjp marked this pull request as draft December 2, 2025 22:08
@databyjp databyjp marked this pull request as ready for review December 11, 2025 11:02
@dirkkul dirkkul merged commit 1067ab8 into main Dec 12, 2025
118 of 121 checks passed
@dirkkul dirkkul deleted the 20251125-model-provider-updates branch December 12, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants