Skip to content

Conversation

@dirkkul
Copy link
Collaborator

@dirkkul dirkkul commented Dec 2, 2025

No description provided.

Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca

Copilot AI review requested due to automatic review settings December 3, 2025 10:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for Weaviate's Object Time-To-Live (TTL) feature, which allows automatic expiration and deletion of objects based on time criteria. The implementation provides three TTL strategies: deletion by creation time, deletion by update time, and deletion by a custom date property.

Key changes:

  • Added _ObjectTTL and _ObjectTTLCreate classes for configuring TTL behavior
  • Integrated TTL configuration into collection creation and management APIs
  • Added support for parsing TTL configuration from Weaviate schema responses

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
weaviate/collections/classes/config_object_ttl.py New file defining TTL configuration classes with three factory methods for different deletion strategies
weaviate/collections/classes/config.py Added ObjectTTLConfig dataclass and integrated it into CollectionConfig classes
weaviate/collections/classes/config_methods.py Added deserialization logic to parse TTL configuration from Weaviate API responses
weaviate/collections/collections/executor.py Added object_ttl_config parameter to create() method signature and documentation
weaviate/collections/collections/sync.pyi Added object_ttl_config parameter type hints for synchronous API
weaviate/collections/collections/async_.pyi Added object_ttl_config parameter type hints for asynchronous API
integration/test_collection_config.py Added three integration tests covering the different TTL deletion strategies
integration/conftest.py Updated collection factory fixture to support object_ttl parameter
mock_tests/test_collection.py Updated test assertion to include object_ttl_config field

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2025

Codecov Report

❌ Patch coverage is 48.25175% with 74 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (dev/1.35@db9d4c2). Learn more about missing BASE report.

Files with missing lines Patch % Lines
integration/test_collection_config.py 29.31% 41 Missing ⚠️
weaviate/collections/classes/config_object_ttl.py 55.76% 23 Missing ⚠️
weaviate/collections/classes/config_methods.py 30.76% 9 Missing ⚠️
weaviate/collections/classes/config.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             dev/1.35    #1899   +/-   ##
===========================================
  Coverage            ?   86.38%           
===========================================
  Files               ?      274           
  Lines               ?    19879           
  Branches            ?        0           
===========================================
  Hits                ?    17172           
  Misses              ?     2707           
  Partials            ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dirkkul dirkkul requested a review from a team as a code owner December 11, 2025 12:15
@dirkkul dirkkul merged commit e0fa645 into dev/1.35 Dec 12, 2025
115 of 118 checks passed
@dirkkul dirkkul deleted the object_ttl branch December 12, 2025 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants