feat: add taskType parameter to google vectorizer #1900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1900 +/- ##
=======================================
Coverage 86.55% 86.56%
=======================================
Files 273 273
Lines 19769 19778 +9
=======================================
+ Hits 17112 17121 +9
Misses 2657 2657 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dirkkul
approved these changes
Dec 3, 2025
| modelId: Optional[str] | ||
| vectorizeClassName: bool | ||
| titleProperty: Optional[str] | ||
| taskType: Optional[str] |
Collaborator
There was a problem hiding this comment.
you can set a default here with taskType: Optional[str] = None and then you don't have to set it for every config manually :)
Collaborator
Author
There was a problem hiding this comment.
Yeah that makes sense. I do see one benefit of this which is that the default is visible on the tooltip.
I'll leave it for now, but add a todo comment to consider making this change, since the whole file is like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add taskType parameter to google vectorizer