[fix]lower wait between retries waiting for threads to close #1907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![orca-security-eu[bot]](https://avatars.githubusercontent.com/in/276244?s=60&v=4){kind=small}
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed |
Infrastructure as Code |  0  0  0  0 |
View in Orca |
| Passed |
SAST | 0 0 0 0 |
View in Orca |
| Passed |
Secrets | 0 0 0 0 |
View in Orca |
| Passed |
Vulnerabilities | 0 0 0 0 |
View in Orca |
tsmith023
approved these changes
Dec 11, 2025
tsmith023
approved these changes
Dec 11, 2025
Collaborator
|
Ah the linter is complaining, I'll fix that quickly for you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a batch stream exits, it hits this check. If a batch did not have a number of elements that exactly matched the batch size the client chose, it would leave a batch thread a live very briefly, and would trigger this wait even though the thread was about to close. This lead to situations where submitting 99 objects in a batch would actually be slower(by about 1 second) than submitting 100 objects.
Lowering this wait means that we do our second check for live threads much more quickly, and so we wait on the client process for .05 seconds instead of 1 second. Testing with Locust confirms this performance improvement.