Closed
Conversation
8ea51c7 to
2ef95e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
array{}shape type annotations to Symfony DI extension and security factory methods, eliminating ~65 baseline entriesAuthenticationExtensions(remove incompatible@readonly, fixoffsetGetreturn type)PublicKeyCredentialRequestOptionsphpdoc typo (AuthenticationExtensions→AuthenticationExtension)TPMAttestationStatementSupport::checkCertInfo()and extractgetRsaParameters()methodis_int,is_stringon already-typed values)realpath()return handling inWebauthnBundleReduces PHPStan baseline from 154 to 90 entries (-42%) while keeping all 275 tests passing.
Test plan
castor phpunit— all 275 tests passcastor phpstan— passes with updated baseline🤖 Generated with Claude Code