fix: harden ClientOverridePolicy defaults#815
Merged
Conversation
… downgrade Change default client override policy for user_verification to deny overrides by default and exclude 'discouraged' from allowed values. This prevents a client from downgrading userVerification to bypass biometric/PIN requirements configured server-side. - ClientOverridePolicy::canOverride() now defaults to false for unknown fields - user_verification.enabled defaults to false (was true) - user_verification.allowed_values defaults to ['required', 'preferred'] (was ['required', 'preferred', 'discouraged']) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClientOverridePolicy::canOverride()fallback changed from?? trueto?? false(defense in depth)user_verification.enabledchanged fromtruetofalseuser_verification.allowed_valueschanged from['required', 'preferred', 'discouraged']to['required', 'preferred']Client requests cannot override the server-configured
userVerificationvalue by default. Administrators who need client-side override flexibility can explicitly opt in via theclient_override_policyconfiguration.Thanks to @restriction for reporting this issue.
Test plan
AuthenticatorSelectionCriteriaConfigTest,Issue797RegressionTest)userVerificationoverrideenabled: truestill allows overrides when configured