fix: reduce PHPStan baseline from 82 to 67 errors#818
Merged
Conversation
…pes and WebauthnBadge
Rector strips inline @var on return statements. Using an intermediate variable preserves the type narrowing that PHPStan needs (parent $data is array|Data, not array<string, mixed>|Data). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Aligns test expectations with the ClientOverridePolicy default change from 'required' to 'preferred' introduced in f0b0241. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WebauthnCollector::getData()Psr18HttpClientanonymous class header types to matchResponseInterfacecovariance@var string[]type assertion forx5cJWT header inFidoAllianceCompliantMetadataServicePublicKeyCredentialCreationOptionsBuilderinterface to match implementationattestationStatementSupportManagerinCompoundAttestationStatementSupportconstructorWebauthnBadgeproperties nullable with defaults and call parentUserBadgeconstructorconvertToDatabaseValue()param tomixedwithassert()for proper contravarianceTest plan
castor phpstanpasses with no errors🤖 Generated with Claude Code