fix: derive compound attestation type from nested types#819
Merged
Conversation
Instead of hardcoding TYPE_BASIC, the compound attestation type is now derived from the nested attestation types by selecting the weakest (least trusted) type. This prevents misrepresenting the trust level when sub-attestations have lower trust than basic. Trust order (strongest to weakest): attca > anonca > basic > self > none Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TYPE_BASICattca>anonca>basic>self>noneContext
Addresses GHSA-7rg8-jq97-qcwr: the
attestationTypelabel on compound attestation statements was hardcoded toTYPE_BASICregardless of the nested attestation types. This could misrepresent the trust level when sub-attestations have lower trust.Test plan
🤖 Generated with Claude Code