Skip to content

Amend: Avoid reallocation in PIN padding #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrts merged 1 commit into from
Jan 15, 2025
Merged

Amend: Avoid reallocation in PIN padding #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/integration/test-authenticate.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ TEST(electronic_id_test, authenticate)
GTEST_ASSERT_GE(cardInfo->eid().authPinRetriesLeft().first, 0U);

byte_vector pin {'1', '2', '3', '4'};
pin.reserve(64);

std::cout << "WARNING! Using hard-coded PIN "
<< std::string_view(reinterpret_cast<const char*>(pin.data()), pin.size()) << '\n';
Expand Down
1 change: 1 addition & 0 deletions tests/integration/test-signing.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ static void signing(HashAlgorithm hashAlgo)
pin = {'1', '2', '3', '4', '5', '6'}; // FinEID custom PIN
else
throw std::runtime_error("TEST signing: Unknown card");
pin.reserve(64);

std::cout << "WARNING! Using hard-coded PIN " << std::string(pin.cbegin(), pin.cend()) << '\n';

Expand Down
Loading