CommandAPDU reuse data object to avoid PIN copy #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrts
reviewed
Sep 13, 2024
| if (size() > MAX_DATA_SIZE) { | ||
| throw std::invalid_argument("Command chaining and extended lenght not supported"); | ||
| } | ||
| insert(begin(), {cls, ins, p1, p2, static_cast<byte_type>(size())}); |
Member
There was a problem hiding this comment.
Isn't it so that when using the T=0 protocol, the Le field should be omitted? Shouldn't you handle protocol differences here?
Contributor
Author
There was a problem hiding this comment.
We have many cases where we send with T=0 Le field and do not have any issues reported:
https://github.com/web-eid/libelectronic-id/blob/main/src/electronic-ids/pcsc/EIDIDEMIA.cpp#L146-L152
https://github.com/web-eid/libelectronic-id/blob/main/src/electronic-ids/pcsc/FinEID.cpp#L161-L162
If this is issue we should handle this in transfer()
Member
There was a problem hiding this comment.
I would prefer that we test T=0 properly after merging.
metsma
force-pushed
the
apdu
branch
2 times, most recently
from
82eacfc to
6da3dc3
Compare
mrts
previously approved these changes
Sep 20, 2024
mrts
reviewed
Sep 20, 2024
metsma
commented
Sep 22, 2024
metsma
force-pushed
the
apdu
branch
3 times, most recently
from
d6ae2af to
fa0cc2c
Compare
WE2-1007 Signed-off-by: Raul Metsma <[email protected]>
WE2-1007 Signed-off-by: Raul Metsma <[email protected]>
WE2-1007 Signed-off-by: Mart Somermaa <[email protected]>
mrts
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WE2-1007
Signed-off-by: Raul Metsma [email protected]