Skip to content

Conversation

@yumisign
Copy link

Hi,

this is a simple implementation for support Luxembourg cards.

Thanks in advance for your feedbacks ;)

Signed-off-by: RCDevs Security

fix syntax

fix atr not exist in scope

Add masked cards map

Format code

enhance support mask
#endif
}

inline fs::path luxembourgPkcs11ModulePath()

Check notice

Code scanning / CodeQL

Unused static function

Static function luxembourgPkcs11ModulePath is unreachable
@mrts mrts requested a review from metsma October 12, 2024 17:21
@mrts
Copy link
Member

mrts commented Oct 12, 2024

Thanks a lot for the fix! We will review and include this as soon as possible.

@mrts
Copy link
Member

mrts commented Dec 3, 2024

We have made an unofficial, untested version 2.6.1 release candidate with support for Luxembourg cards and new version of Croatian eID middleware, it is available here.

I included your work by cherry-picking your commit to this PR: #92.

Thanks for your contribution again! Please test v2.6.1-rc1 and let us know if it works as expected.

@mrts
Copy link
Member

mrts commented Dec 6, 2024

I tuned the masked ATR support code a bit and made turning off extKeyUsage check more general, superseded by https://github.com/web-eid/libelectronic-id/pull/96/files

@mrts
Copy link
Member

mrts commented Dec 6, 2024

We have made the third unofficial, untested version 2.6.1 release candidate that contains support for Luxembourg cards, new version of Croatian eID middleware and fixed BelEID v1.7 support, it is available here.

Please test v2.6.1-rc3 and let us know if it works as expected.

Thanks in advance for your help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants