Skip to content

Commit 69672ab

Browse files
metsmamrts
authored andcommitted
Format name only when SN ang GN are available
WE2-738 Signed-off-by: Raul Metsma <[email protected]>
1 parent f5d9125 commit 69672ab

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/controller/command-handlers/certificatereader.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,10 +51,11 @@ CardCertificateAndPinInfo getCertificateWithStatusAndInfo(const CardInfo::ptr& c
5151
auto serialNumber = certificate.subjectInfo(QSslCertificate::SerialNumber).join(' ');
5252

5353
// http://www.etsi.org/deliver/etsi_en/319400_319499/31941201/01.01.01_60/en_31941201v010101p.pdf
54-
if(serialNumber.size() > 6 && serialNumber.startsWith(QStringLiteral("PNO")) && serialNumber[5] == '-')
54+
if (serialNumber.size() > 6 && serialNumber.startsWith(QStringLiteral("PNO"))
55+
&& serialNumber[5] == '-')
5556
serialNumber.remove(0, 6);
5657

57-
if (!givenName.isEmpty() || !surName.isEmpty()) {
58+
if (!givenName.isEmpty() && !surName.isEmpty() && !serialNumber.isEmpty()) {
5859
subject = QStringLiteral("%1, %2, %3").arg(surName, givenName, serialNumber);
5960
}
6061

0 commit comments

Comments
 (0)