feat(core): add GPT-5 model support with Responses API #1193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for midscene ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
|
- Automatically detect GPT-5 models by name - Use max_completion_tokens instead of max_tokens for GPT-5 - Handle GPT-5's temperature restrictions (only supports default) - Parse GPT-5 Responses API response format - Add tests for GPT-5 functionality - Update documentation with GPT-5 configuration Fixes web-infra-dev#1060 🤖 Generated with Claude Code Co-Authored-By: Claude <[email protected]>
kidandcat
force-pushed
the
feat/gpt5-support
branch
from
43fcd27 to
8f41248
Compare
kidandcat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements support for GPT-5 models in Midscene, addressing issue #1060.
Changes
max_completion_tokensinstead ofmax_tokensfor GPT-5 modelsImplementation Details
The implementation automatically detects GPT-5 models and adjusts the API request parameters accordingly:
max_tokenswithmax_completion_tokensTesting
Tested with model
gpt-5-nano-2025-08-07:Usage
The system will automatically detect GPT-5 models and use the Responses API with appropriate parameters.
Fixes #1060
🤖 Generated with Claude Code