Skip to content

Conversation

quanru
Copy link
Collaborator

@quanru quanru commented Sep 25, 2025

Summary

  • Add screenshotResizeRatio option to AndroidDeviceOpt interface for customizing screenshot dimensions
  • Apply custom resize ratio in screenshotBase64() method with default value of 1.0
  • Add comprehensive unit tests covering different resize ratio scenarios
  • Include debug logging for resize operations when custom ratio is applied

Test plan

  • Add unit tests for custom resize ratio functionality
  • Add unit tests for default behavior (ratio 1.0)
  • Add unit tests for undefined ratio handling
  • Verify existing screenshot functionality remains unchanged
  • Test with real Android device using different resize ratios

🤖 Generated with Claude Code

Copy link

netlify bot commented Sep 25, 2025

Deploy Preview for midscene ready!

Name Link
🔨 Latest commit 4cd4a17
🔍 Latest deploy log https://app.netlify.com/projects/midscene/deploys/68e359097eeccc00086b958c
😎 Deploy Preview https://deploy-preview-1243--midscene.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@quanru quanru changed the title feat(android): add screenshotResizeRatio option for custom screenshot resizing WIP: feat(android): add screenshotResizeRatio option for custom screenshot resizing Sep 25, 2025
@quanru quanru force-pushed the feat/android-screenshot-resize-ratio branch 4 times, most recently from fb97907 to a201d73 Compare September 30, 2025 06:16
@quanru quanru changed the title WIP: feat(android): add screenshotResizeRatio option for custom screenshot resizing feat(android): add screenshotResizeRatio option for custom screenshot resizing Oct 6, 2025
@quanru quanru force-pushed the feat/android-screenshot-resize-ratio branch from 530f5ba to 6ec0eb1 Compare October 6, 2025 05:26
@quanru quanru force-pushed the feat/android-screenshot-resize-ratio branch from b88ae5f to 4cd4a17 Compare October 6, 2025 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants