-
Notifications
You must be signed in to change notification settings - Fork 921
feat(visualizer): device-aware shell rendering with Remotion Player #2023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 24 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
405ca4c
feat(player): add opening and step scenes for video player
quanru 850657b
feat(visualizer): implement cyberpunk visual effects in video export
quanru 7fdeaa3
feat(visualizer): enhance browser shell with 3D effects and chrome el…
quanru b2492f6
feat(visualizer): introduce ScriptFrame data structure and refactor c…
quanru f7066e6
fix(player): improve player frame retrieval and enhance subtitle hand…
quanru 7a94f3d
refactor(blackboard): remove unused PIXI imports and enhance overlay …
quanru 3a6249e
feat(visualizer): enhance device support in visualizer
quanru fd1ed87
refactor(visualizer): implement frame state derivation for Remotion p…
quanru ec375c3
feat(player): disable volume controls in Player component
quanru c3ffe8d
feat(player): embed toolbar controls into Remotion Player control bar
quanru 76f737c
feat(player): add fullscreen button with shared icon style in Remotio…
quanru 223408c
refactor(export-branded-video): improve variable declaration formatti…
quanru 445647f
feat(player): enhance device shell rendering and improve progress cal…
quanru 214fe63
feat(player): update custom controls with play/pause button and impro…
quanru 2b2f1b6
feat(player): add chapter markers overlay and improve player wrapper …
quanru 6be444a
feat(player): update styles for chapter markers and seek bar, enhance…
quanru 52e8d32
feat(player): enhance player wrapper for aspect ratio handling and po…
quanru 6bd2465
feat(player): improve device shell rendering for portrait mode and en…
quanru d357bbb
refactor(player): remove effects system and add subtitle toggle
quanru d0062c0
fix(report): prevent layout overlap when browser width shrinks
quanru 434e006
feat(player): enhance layout for sidebar resizing and remove device t…
quanru f162f7e
refactor(player): simplify layout calculations for portrait mode in S…
quanru 060059d
refactor(report): replace pixi.js with Canvas 2D in Timeline and clea…
quanru bc09655
feat(player): implement frame player hook and enhance player controls…
quanru f5c5728
fix(player): improve resource cleanup for report downloads and video …
quanru 8977df1
feat(player): add subtitle rendering and styling to enhance user expe…
quanru File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sidebarWidthis initialized fromlocalStorageusingNumber(saved)without validation. If the stored value is missing/invalid, this can becomeNaNand result in an invalidstyle.width. Consider validating/clamping the parsed value (and falling back toDEFAULT_SIDEBAR_WIDTHwhenNumber.isFiniteis false).