chore(core): rename ExecutionSession to SessionRecord for clarity#2147
Merged
ottomao merged 1 commit intofeat/session-report-exportfrom Mar 13, 2026
Merged
Conversation
The ExecutionSession interface in execution-store.ts shared its name with the ExecutionSession class in execution-session.ts despite having no relationship. Rename the interface to SessionRecord (and its input type to EnsureSessionRecordInput) to clarify that it represents a persisted session record on disk, not a runtime execution wrapper. https://claude.ai/code/session_01HXDdDG5C2trBndJzD8kWHk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR renames the
ExecutionSessioninterface and related types toSessionRecordto better reflect their purpose as persistent data records rather than active execution sessions.Key Changes
ExecutionSessioninterface toSessionRecordthroughout the codebaseEnsureExecutionSessionInputinterface toEnsureSessionRecordInputExecutionStoreclass methods:load()return typesave()parameter and return typeensureSession()parameter and return typemarkReportGenerated()return typeSessionRecordnameindex.tsto reflect the new interface namesImplementation Details
The renaming is purely a nomenclature change with no functional modifications. All method signatures, logic, and behavior remain identical. This improves code clarity by distinguishing between the persistent session records stored on disk and the runtime execution context.
https://claude.ai/code/session_01HXDdDG5C2trBndJzD8kWHk