shim only on current format

Author: fi3ework

packages/core/src/config.ts

@@ -1124,7 +1124,8 @@ async function composeLibRsbuildConfig(config: LibConfig, configPath: string) {
   );
   const cssConfig = composeCssConfig(lcp, config.bundle);
   const entryChunkConfig = composeEntryChunkConfig({
-    enabledImportMetaUrlShim: !!resolvedShims?.cjs?.['import.meta.url'],
+    enabledImportMetaUrlShim:
+      format === 'cjs' && !!resolvedShims?.cjs?.['import.meta.url'],
   });
   const dtsConfig = await composeDtsConfig(config, dtsExtension);
   const externalsWarnConfig = composeExternalsWarnConfig(

packages/core/src/plugins/EntryChunkPlugin.ts

@@ -112,28 +112,28 @@ class EntryChunkPlugin {
 
     compiler.hooks.make.tap(PLUGIN_NAME, (compilation) => {
       compilation.hooks.processAssets.tap(PLUGIN_NAME, (assets) => {
+        if (!this.enabledImportMetaUrlShim) return;
+
         const chunkAsset = Object.keys(assets);
         for (const name of chunkAsset) {
-          if (this.enabledImportMetaUrlShim) {
-            compilation.updateAsset(name, (old) => {
-              const oldSource = old.source().toString();
-              const replaceSource = new rspack.sources.ReplaceSource(old);
-              if (
-                oldSource.startsWith('use strict;') ||
-                oldSource.startsWith('"use strict";')
-              ) {
-                replaceSource.replace(
-                  0,
-                  11, // 'use strict;'.length,
-                  `"use strict";${os.EOL}${importMetaUrlShim}`,
-                );
-              } else {
-                replaceSource.insert(0, importMetaUrlShim);
-              }
-
-              return replaceSource;
-            });
-          }
+          compilation.updateAsset(name, (old) => {
+            const oldSource = old.source().toString();
+            const replaceSource = new rspack.sources.ReplaceSource(old);
+            if (
+              oldSource.startsWith('use strict;') ||
+              oldSource.startsWith('"use strict";')
+            ) {
+              replaceSource.replace(
+                0,
+                11, // 'use strict;'.length,
+                `"use strict";${os.EOL}${importMetaUrlShim}`,
+              );
+            } else {
+              replaceSource.insert(0, importMetaUrlShim);
+            }
+
+            return replaceSource;
+          });
         }
       });
 

tests/integration/minify/index.test.ts

@@ -16,13 +16,7 @@ test('tree shaking is disabled by the user, bar and baz should be kept', async (
   const fixturePath = join(__dirname, 'config');
   const { entries } = await buildAndGetResults({ fixturePath });
   expect(entries.esm).toMatchInlineSnapshot(`
-    "const __rslib_import_meta_url__ = /*#__PURE__*/ (function () {
-      return typeof document === 'undefined'
-        ? new (require('url'.replace('', '')).URL)('file:' + __filename).href
-        : (document.currentScript && document.currentScript.src) ||
-          new URL('main.js', document.baseURI).href;
-    })();
-
+    "
     ;// CONCATENATED MODULE: ../__fixtures__/src/index.ts?__rslib_entry__
     const foo = ()=>{};
     const bar = ()=>{};