fix: determine wasmLoading by target #1136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the automatic determination of the wasmLoading configuration option by removing explicit settings and allowing Rspack to infer the correct value based on the target environment rather than the module format.
- Removes hardcoded
wasmLoadingvalues from format configuration - Updates test snapshots to reflect the removal of explicit
wasmLoadingsettings
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/config.ts | Removes explicit wasmLoading configuration for both ESM and CommonJS formats |
| packages/core/tests/snapshots/config.test.ts.snap | Updates test snapshots to reflect removed wasmLoading properties |
Timeless0911
approved these changes
Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
wasmLoaing can be correctly inferred by Rspack. it should not be determined by module format.
Related Links
Checklist