fix(dts): clean correct tsbuildinfo file #1138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the cleanTsBuildInfoFile function to ensure it correctly resolves the path to the TypeScript build info file for deletion. The fix addresses issue #1134 by improving the path resolution logic for tsBuildInfo files.
- Fixed path resolution logic for tsBuildInfo files when custom paths are specified
- Added comprehensive test coverage for various tsconfig configurations
- Updated test structure to use describe blocks for better organization
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| packages/plugin-dts/src/utils.ts | Fixed the cleanTsBuildInfoFile function to properly handle absolute and relative tsBuildInfo file paths |
| packages/plugin-dts/tests/utils.test.ts | Added comprehensive tests for the fixed function and reorganized existing tests into describe blocks |
fi3ework
approved these changes
Aug 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
clean correct build info file
Related Links
close: #1134
Checklist