Skip to content

Conversation

@Timeless0911
Copy link
Contributor

@Timeless0911 Timeless0911 commented Aug 1, 2025

Summary

This PR brings some import changes:

export star cause random output

fix PR: web-infra-dev/rspack#11229

close: #882
close: #1007

preserve magic comments

support PR: web-infra-dev/rspack#11218

close: #1131

Users can modify minify configurations to set comments: 'all' to keep magic comments in output.

see https://rslib.rs/config/rsbuild/output#outputminify

e.g.

export default defineConfig({
  output: {
    minify: {
      js: true,
      css: false,
      jsOptions: {
        minimizerOptions: {
          mangle: false,
          minify: false,
          compress: {
            defaults: false,
            unused: true,
            dead_code: true,
            toplevel: true,
          },
          format: {
-           comments: 'some',
+           comments: 'all',
            preserve_annotations: true,
          },
        },
      },
    },
  },
});

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings August 1, 2025 07:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Rsbuild dependency from version 1.4.11 to 1.4.12 across the entire monorepo to bring important bug fixes and feature improvements.

  • Fixes export star causing random output issues
  • Adds support for preserving magic comments in bundled code
  • Updates all package.json files consistently across the project

Reviewed Changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated no comments.

Show a summary per file
File Description
website/package.json Updates @rsbuild/core dependency to 1.4.12
tests/package.json Updates @rsbuild/core dependency to 1.4.12
packages/plugin-dts/package.json Updates @rsbuild/core dependency to 1.4.12
packages/create-rslib/template-[vue]-[storybook]-ts/package.json Updates @rsbuild/core dependency to 1.4.12
packages/create-rslib/template-[vue]-[storybook]-js/package.json Updates @rsbuild/core dependency to 1.4.12
packages/create-rslib/template-[vue]-[storybook,vitest]-ts/package.json Updates @rsbuild/core dependency to 1.4.12
packages/create-rslib/template-[vue]-[storybook,vitest]-js/package.json Updates @rsbuild/core dependency to 1.4.12
packages/create-rslib/template-[react]-[storybook]-ts/package.json Updates @rsbuild/core dependency to 1.4.12
packages/create-rslib/template-[react]-[storybook]-js/package.json Updates @rsbuild/core dependency to 1.4.12
packages/create-rslib/template-[react]-[storybook,vitest]-ts/package.json Updates @rsbuild/core dependency to 1.4.12
packages/create-rslib/template-[react]-[storybook,vitest]-js/package.json Updates @rsbuild/core dependency to 1.4.12
packages/create-rslib/fragments/tools/storybook-vue-ts/package.json Updates @rsbuild/core dependency to 1.4.12
packages/create-rslib/fragments/tools/storybook-vue-js/package.json Updates @rsbuild/core dependency to 1.4.12
packages/create-rslib/fragments/tools/storybook-react-ts/package.json Updates @rsbuild/core dependency to 1.4.12
packages/create-rslib/fragments/tools/storybook-react-js/package.json Updates @rsbuild/core dependency to 1.4.12
packages/core/package.json Updates @rsbuild/core dependency to 1.4.12
examples/module-federation/mf-remote/package.json Updates @rsbuild/core dependency to 1.4.12
examples/module-federation/mf-host/package.json Updates @rsbuild/core dependency to 1.4.12
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

@netlify
Copy link

netlify bot commented Aug 1, 2025

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit 958f6d6
🔍 Latest deploy log https://app.netlify.com/projects/rslib/deploys/688c689b6edca3000859f7aa
😎 Deploy Preview https://deploy-preview-1139--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Timeless0911 Timeless0911 enabled auto-merge (squash) August 1, 2025 07:17
@Timeless0911 Timeless0911 merged commit e04c0a3 into main Aug 1, 2025
16 checks passed
@Timeless0911 Timeless0911 deleted the chore/bump-rsbuild-1412 branch August 1, 2025 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: SVG imports with same filename as JS import cause issues in bundleless [Bug]: export star statement is unstable

3 participants