Skip to content

Conversation

@fi3ework
Copy link
Member

@fi3ework fi3ework commented Aug 6, 2025

Summary

Rslint yes.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copilot AI review requested due to automatic review settings August 6, 2025 11:18
@netlify
Copy link

netlify bot commented Aug 6, 2025

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit dd218c4
🔍 Latest deploy log https://app.netlify.com/projects/rslib/deploys/68933f14930f5f00085212fc
😎 Deploy Preview https://deploy-preview-1151--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Rslint (a TypeScript linter) to the project as a development tool and includes associated code changes to address various linting issues throughout the codebase.

  • Adds Rslint configuration and integrates it into the linting workflow
  • Fixes multiple TypeScript and JavaScript code style issues identified by the linter
  • Updates function calls, boolean comparisons, and string template usage for better code quality

Reviewed Changes

Copilot reviewed 13 out of 14 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
rslint.jsonc Adds Rslint configuration with TypeScript rules (mostly disabled initially)
package.json Adds @rslint/core dependency and integrates lint:type script into main lint command
packages/plugin-dts/src/utils.ts Fixes function binding, template string usage, and async function declarations
packages/plugin-dts/src/tsc.ts Fixes function binding for TypeScript system methods
packages/plugin-dts/src/index.ts Fixes function binding for TypeScript file existence check
packages/plugin-dts/src/dts.ts Simplifies boolean comparisons and removes unnecessary non-null assertions
packages/plugin-dts/src/apiExtractor.ts Removes unnecessary non-null assertion and redundant string operations
packages/core/src/utils/logger.ts Removes unnecessary template string wrapping
packages/core/src/utils/helper.ts Updates array type syntax for consistency
packages/core/src/css/libCssExtractLoader.ts Fixes non-null assertions and string coercion
packages/core/src/css/cssConfig.ts Refactors return statements to use early returns consistently
packages/core/src/config.ts Improves boolean comparisons, early returns, and removes unnecessary type assertions
packages/core/src/cli/prepare.ts Removes unnecessary template string wrapping
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)

package.json:46

  • The package @rslint/core version ^0.1.5 may not exist. Based on the PR description mentioning Rslint from web-infra-dev/rslint, verify this is the correct package name and version.
    "@rslint/core": "^0.1.5",

Timeless0911
Timeless0911 previously approved these changes Aug 6, 2025
@Timeless0911 Timeless0911 changed the title chore: add Rslint chore: integrate Rslint for type-aware linting Aug 6, 2025
@Timeless0911 Timeless0911 enabled auto-merge (squash) August 6, 2025 11:44
Timeless0911
Timeless0911 previously approved these changes Aug 6, 2025
@Timeless0911 Timeless0911 merged commit 66c575c into main Aug 6, 2025
14 checks passed
@Timeless0911 Timeless0911 deleted the rslint branch August 6, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants