fix: only force split async chunks when format is esm or cjs #1152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the splitChunks configuration by only forcing async chunk splitting when the output format is ESM or CommonJS, rather than applying it globally to all formats.
- Moves
splitChunks: { chunks: 'async' }from global configuration to format-specific configurations - Adds the configuration to both ESM and CommonJS format handlers
- Removes the global setting that was previously applied to all formats
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/src/config.ts | Moves splitChunks configuration from global to format-specific (ESM/CJS) sections |
| packages/core/tests/snapshots/config.test.ts.snap | Updates test snapshots to reflect the new configuration placement |
fi3ework
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
only force split async chunks when format is esm or cjs
Related Links
Checklist