test: replace npx with a faster helper #1154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes test execution by replacing slow npx commands with a faster direct Node.js helper for running the rslib CLI. Instead of using npx rslib which has overhead from package resolution, tests now use direct node execution with a pre-resolved path to the rslib binary.
Key changes:
- Introduced helper functions
runCliandrunCliSyncthat execute rslib commands directly via Node.js - Replaced all
npx rslibcalls in test files with the new helper functions - Added direct binary path resolution for faster command execution
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/scripts/shared.ts | Added helper functions and binary path resolution for direct rslib CLI execution |
| tests/integration/server/index.test.ts | Replaced npx rslib with runCli helper for mf-dev command |
| tests/integration/plugins/index.test.ts | Replaced npx rslib with runCli helper for mf-dev command |
| tests/integration/cli/mf/mf.test.ts | Replaced npx rslib calls with runCli and runCliSync helpers |
| tests/integration/cli/inspect/inspect.test.ts | Replaced npx rslib calls with runCliSync helper |
| tests/integration/cli/env/env.test.ts | Replaced npx rslib calls with runCliSync helper |
| tests/integration/cli/build/build.test.ts | Replaced npx rslib calls with runCliSync helper |
| tests/integration/cli/build-watch/build.test.ts | Replaced npx rslib and spawn calls with new helpers and direct binary path |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
replace npx with a faster helper
before
after
Related Links
web-infra-dev/rsbuild#5784
Checklist