Skip to content

Conversation

@Timeless0911
Copy link
Contributor

@Timeless0911 Timeless0911 commented Aug 12, 2025

Summary

Rspack and Rsbuild v1.5 will no longer support Node 16, as Node.js reached end-of-life on September 11th, 2023, and many npm packages in the ecosystem have also dropped support for Node 16.

This PR update the engines field in package.json to require Node.js >= 18.12.0.

Related Links

web-infra-dev/rspack#10867

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the minimum Node.js version requirement across the project to align with Rspack and Rsbuild v1.5's dropping of Node 16 support, which reached end-of-life in September 2023.

  • Updates engines.node field from various versions (16.7.0, 18.0.0) to consistently require 18.12.0
  • Ensures consistency across all package.json files in the monorepo
  • Aligns with ecosystem-wide trend of dropping Node 16 support

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/plugin-dts/package.json Updates minimum Node.js version from 16.7.0 to 18.12.0
packages/create-rslib/package.json Updates minimum Node.js version from 16.7.0 to 18.12.0
packages/core/package.json Updates minimum Node.js version from 16.7.0 to 18.12.0
package.json Updates minimum Node.js version from 18.0.0 to 18.12.0

@netlify
Copy link

netlify bot commented Aug 12, 2025

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit 0142f27
🔍 Latest deploy log https://app.netlify.com/projects/rslib/deploys/689af49ae14f600008e36296
😎 Deploy Preview https://deploy-preview-1159--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Aug 12, 2025

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit 19e421b
🔍 Latest deploy log https://app.netlify.com/projects/rslib/deploys/689af60c70a95400083133d9
😎 Deploy Preview https://deploy-preview-1159--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@Timeless0911 Timeless0911 merged commit 15411e6 into main Aug 12, 2025
14 checks passed
@Timeless0911 Timeless0911 deleted the drop-node-16 branch August 12, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants