-
-
Notifications
You must be signed in to change notification settings - Fork 53
fix: should glob dot files in bundleless mode #1196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: should glob dot files in bundleless mode #1196
Conversation
|
Thanks, can you add this case to tests |
|
It seems that when the file name contains a dot, an incorrect export is generated. Actual behaviorexport * from ".hiddenFile.js";Expected behaviorexport * from "./.hiddenFile.js"; |
|
This require a fix here that the logic of determine whether it is a relative path rslib/packages/core/src/config.ts Lines 1347 to 1352 in 1bced60
I think we can modify like this: if (
!resolvedRequest.startsWith('./') &&
!resolvedRequest.startsWith('../')
) {
resolvedRequest = `./${resolvedRequest}`;
} |
|
Can I submit to this pr? |
|
Thanks a lot!
I think you’ll be able to submit it much faster than I could, so please go ahead and submit to the PR. |
Summary
Add an option to prevent glob from ignoring directories starting with a dot.
Related Links
close #1195
Checklist