fix(dts): tsgo bin path should begin with file protocol in windows #1211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a Windows-specific issue where dynamic imports of absolute file paths fail because Windows requires proper file:// URL protocol formatting. The fix ensures cross-platform compatibility for the tsgo binary path resolution.
- Adds proper Windows file path handling using
pathToFileURLfrom Node.js - Conditionally formats file paths as file:// URLs on Windows while preserving existing behavior on other platforms
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
fi3ework
previously approved these changes
Sep 9, 2025
Timeless0911
force-pushed
the
fix/windows
branch
from
f36e8b1 to
3494a17
Compare
fi3ework
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
tsgo bin path should begin with file protocol in windows
Related Links
https://github.com/lynx-family/lynx-stack/actions/runs/17573565390/job/49914064104?pr=1685
Checklist