feat!: config loader default to 'auto'
#1240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces a new 'auto' option for the --config-loader CLI parameter and changes the default from 'jiti' to 'auto'. The auto mode attempts to use Node.js's native loader first and falls back to jiti if it fails.
- Add
'auto'as a new config loader option that tries native loader first, then falls back to jiti - Change the default config loader from
'jiti'to'auto' - Update documentation to reflect the new options and provide guidance on Node.js native loader limitations
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/config.ts | Add 'auto' to ConfigLoader type definition |
| packages/core/src/cli/commands.ts | Update CLI option description and change default to 'auto' |
| website/docs/en/guide/basic/cli.mdx | Update English CLI documentation to include 'auto' option |
| website/docs/zh/guide/basic/cli.mdx | Update Chinese CLI documentation to include 'auto' option |
| website/docs/en/guide/basic/configure-rslib.mdx | Update English configuration guide with new loader options and limitations |
| website/docs/zh/guide/basic/configure-rslib.mdx | Update Chinese configuration guide with new loader options and limitations |
| tests/integration/cli/build/rslib.config.auto.mts | Add test configuration file for auto loader functionality |
| tests/integration/cli/build/path.json | Add JSON file for test configuration |
| tests/integration/cli/build/build.test.ts | Add test case for auto loader fallback behavior |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
fi3ework
reviewed
Sep 23, 2025
Co-authored-by: Wei <[email protected]>
Co-authored-by: Wei <[email protected]>
fi3ework
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
'auto'for--config-loadercli options to use Node.js's native loader to load configuration files first, and fallback to using jiti if it fails.Breaking change:
The default value changes from
jititonative.More details, see RFC web-infra-dev/rsbuild#6188
Related Links
--config-loader autorsbuild#6186--config-loaderoption #1225Checklist