-
-
Notifications
You must be signed in to change notification settings - Fork 57
fix(create-rslib): drop legacy Storybook packages #1252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates Storybook configuration to align with v9 migration requirements by removing legacy packages that are no longer available as separate packages in v9, and replacing them with the new internal paths. The changes also simplify the setup by removing non-essential addons to provide a minimal basic configuration.
- Updates import paths for
@storybook/testto use the newstorybook/testpath - Removes deprecated packages like
@storybook/addon-essentials,@storybook/addon-interactions,@storybook/blocksfrom package.json files - Removes
@storybook/addon-linksaddon from configurations to align with official minimal setup - Updates documentation to reflect the new package structure and installation commands
Reviewed Changes
Copilot reviewed 54 out of 55 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| website/docs/zh/guide/advanced/storybook.mdx | Updates Chinese documentation with new package installation commands and addon configuration |
| website/docs/en/guide/advanced/storybook.mdx | Updates English documentation with new package installation commands and addon configuration |
| Multiple template and fragment files | Removes legacy Storybook packages from package.json and updates import paths in story files |
| examples/vue-component-bundleless/* | Updates example project to use new Storybook v9 structure |
| packages/create-rslib/AGENTS.md | Minor grammar improvement in development documentation |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Timeless0911
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also update examples in https://github.com/rspack-contrib/rstack-examples/tree/main/rslib
Summary
storybookinternally. this PR is to drop all these packages, and use the new path. no alpha tag packages anymore.@storybook/addon-linksto align with official sandbox demo, this scaffold is to provide a minimal basic setup for users.Related Links
Checklist