Skip to content

Conversation

Timeless0911
Copy link
Contributor

Summary

This pull request updates the documentation for both English and Chinese guides to clarify and improve instructions for using environment variables in Rslib configuration files. The changes focus on explaining default behaviors, providing practical examples for dynamic configuration, and refining the sample code for aliasing based on environment variables.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@Copilot Copilot AI review requested due to automatic review settings October 13, 2025 11:27
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates documentation to better explain environment variable usage in Rslib configuration files, focusing on clarifying default behaviors and distinguishing watch mode configurations.

  • Adds comprehensive examples for using watch mode to dynamically configure aliases
  • Clarifies that process.env.NODE_ENV is always 'production' during builds
  • Replaces generic NODE_ENV examples with more practical scenarios like language selection

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
website/docs/zh/guide/basic/configure-rslib.mdx Updates Chinese docs to use language-based alias example instead of NODE_ENV
website/docs/zh/guide/basic/cli.mdx Adds watch mode detection example and clarifies NODE_ENV behavior in Chinese
website/docs/en/guide/basic/configure-rslib.mdx Updates English docs to use language-based alias example instead of NODE_ENV
website/docs/en/guide/basic/cli.mdx Adds watch mode detection example and clarifies NODE_ENV behavior in English

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

netlify bot commented Oct 13, 2025

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit 2061641
🔍 Latest deploy log https://app.netlify.com/projects/rslib/deploys/68ece23028490f000838b3c6
😎 Deploy Preview https://deploy-preview-1265--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@fi3ework fi3ework merged commit ea12ee8 into main Oct 14, 2025
15 checks passed
@fi3ework fi3ework deleted the docs/watch-mode branch October 14, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants