fix: merge output.distPath correctly
#1270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the merging of output.distPath configuration by ensuring consistent object types. When users provide a string value for output.distPath, it's now converted to an object format before merging with Rslib's built-in object-type configuration.
- Adds string-to-object conversion for
output.distPathin the config composition logic - Includes comprehensive test coverage for both string and object
distPathconfigurations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/core/src/config.ts | Implements the distPath conversion logic to handle string inputs |
| packages/core/tests/config.test.ts | Adds test cases validating correct merging behavior for both formats |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
fi3ework
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
user config: string type of
output.distPathRslib built-in config: object type of
output.distPathMerge them correctly in Rslib until Rsbuild support merge different type of
output.distPath.Related Links
Checklist