Skip to content

Conversation

Timeless0911
Copy link
Contributor

Summary

Use shorter string value for output.distPath.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@Copilot Copilot AI review requested due to automatic review settings October 15, 2025 12:36
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR simplifies the configuration syntax for output.distPath across the codebase by using a shorter string value instead of an object with a root property. The change affects documentation, test files, examples, and shared test utilities.

Key Changes

  • Updated output.distPath from object syntax ({ root: './dist/path' }) to string syntax ('./dist/path')
  • Modified helper functions in test utilities to use the shorter syntax
  • Updated code highlight line numbers in documentation to reflect the reduced line count

Reviewed Changes

Copilot reviewed 70 out of 70 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
website/docs/zh/guide/solution/nodejs.mdx Simplified distPath in Chinese Node.js solution docs
website/docs/zh/guide/basic/output-format.mdx Simplified distPath in Chinese output format docs
website/docs/zh/guide/advanced/module-federation.mdx Simplified distPath and adjusted highlight comment in Chinese module federation docs
website/docs/en/guide/solution/nodejs.mdx Simplified distPath in English Node.js solution docs
website/docs/en/guide/basic/output-format.mdx Simplified distPath in English output format docs
website/docs/en/guide/advanced/module-federation.mdx Simplified distPath and adjusted highlight comment in English module federation docs
tests/scripts/shared.ts Updated helper functions to use string distPath syntax
tests/integration/**/*.ts Simplified distPath across all integration test configurations
examples/**/*.ts Simplified distPath in example project configurations

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

netlify bot commented Oct 15, 2025

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit 75d5c10
🔍 Latest deploy log https://app.netlify.com/projects/rslib/deploys/68ef955e9edd1c00088abdea
😎 Deploy Preview https://deploy-preview-1271--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@fi3ework fi3ework enabled auto-merge (squash) October 15, 2025 12:43
@fi3ework fi3ework merged commit 0a56962 into main Oct 15, 2025
15 checks passed
@fi3ework fi3ework deleted the string/dist-path branch October 15, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants