Skip to content

Conversation

Timeless0911
Copy link
Contributor

Summary

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@Copilot Copilot AI review requested due to automatic review settings October 15, 2025 12:50
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a type checking bug in the shims disable test configuration. The original code incorrectly checked if distPath was an object when it should have been checking for string, leading to the condition never being true and the path replacement never executing.

Key Changes:

  • Corrected type guard from object to string for distPath
  • Simplified the path replacement logic to directly assign to distPath

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Timeless0911 Timeless0911 merged commit 810fc51 into main Oct 16, 2025
15 checks passed
@Timeless0911 Timeless0911 deleted the fix.test branch October 16, 2025 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants