chore: add type module to package.json in examples #1313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds "type": "module" to package.json files across multiple example packages, standardizing them to use ES modules as the default module system. All example packages in the repository now explicitly declare their module type.
- Adds
"type": "module"field to 8 example packages - Ensures consistency across all example packages that already had this field
- Aligns package configuration with modern Node.js and TypeScript practices
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| examples/react-component-umd/package.json | Added module type declaration to UMD React component example |
| examples/react-component-bundle/package.json | Added module type declaration to bundled React component example |
| examples/react-component-bundle-false/package.json | Added module type declaration to bundleless React component example |
| examples/preact-component-bundle-false/package.json | Added module type declaration to bundleless Preact component example |
| examples/module-federation/mf-remote/package.json | Added module type declaration to module federation remote example |
| examples/module-federation/mf-react-component/package.json | Added module type declaration to module federation React component example |
| examples/module-federation/mf-host/package.json | Added module type declaration to module federation host example |
| examples/express-plugin/package.json | Added module type declaration to Express plugin example |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fi3ework
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
"type": "module"topackage.jsonin examples. This makes native loader load configuration files without warning.Related Links
Checklist