fix(create-rslib): support repeatable —tools flag
#1328
Merged
+140
−121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for repeatable --tools flags in the create-rslib CLI, allowing users to specify multiple tools by repeating the flag (e.g., --tools storybook --tools biome). This fixes issue #426.
Key changes:
- Updated
create-rstackdependency from 1.7.4 to 1.7.6 to support repeatable flag handling - Refactored test suite to use structured
TemplateCaseobjects instead of string-based template names - Updated documentation examples to demonstrate the new repeatable
--toolsflag syntax
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/create-rslib/package.json | Updated create-rstack dependency to 1.7.6 |
| pnpm-lock.yaml | Updated lockfile to reflect new create-rstack version |
| packages/create-rslib/src/index.ts | Modified template name parsing to handle tools from argv and compose template names |
| packages/create-rslib/test/index.test.ts | Refactored test cases to use TemplateCase interface with structured data |
| packages/create-rslib/test/helper.ts | Updated test helper to accept TemplateCase objects and build commands with repeatable --tools flags |
| website/docs/en/guide/start/quick-start.mdx | Updated documentation to show repeatable --tools flag usage with concrete example |
| website/docs/zh/guide/start/quick-start.mdx | Updated Chinese documentation to show repeatable --tools flag usage with concrete example |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Timeless0911
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix #426.
Related Links
Checklist