Skip to content

Conversation

@fi3ework
Copy link
Member

@fi3ework fi3ework commented Oct 10, 2024

Summary

Ref: #266 (comment)

  • lock benchmark node version
  • run integration tests on 18 20 22
  • clean ci

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@codspeed-hq
Copy link

codspeed-hq bot commented Oct 10, 2024

CodSpeed Performance Report

Merging #267 will degrade performances by 16.87%

Comparing cicicici (e946754) with main (c8c1726)

Summary

❌ 2 regressions

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main cicicici Change
examples/express-plugin 99 ms 119 ms -16.87%
examples/react-component 100.4 ms 116.5 ms -13.81%

@Timeless0911
Copy link
Contributor

https://github.com/web-infra-dev/rslib/settings/branch_protection_rules/50836504 we should modify this settings if we rename the ci pipeline

image

@fi3ework
Copy link
Member Author

@Timeless0911 Got it, I'll modify it after PR got approved.

@fi3ework fi3ework requested a review from SoonIter October 10, 2024 07:54
Copy link
Member

@SoonIter SoonIter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Timeless0911 Timeless0911 merged commit 69f726a into main Oct 10, 2024
15 of 16 checks passed
@Timeless0911 Timeless0911 deleted the cicicici branch October 10, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants