Skip to content

fix: map syntax "es6" to "es2015" #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2024
+20 −1
Merged

fix: map syntax "es6" to "es2015" #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b4b12c
fix: map "es6" to "es2015"
wChenonly Oct 23, 2024
09ef5a1
fix: map "es6" to "es2015"
wChenonly Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/core/src/utils/syntax.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,10 @@ export function transformSyntaxToRspackTarget(
) {
return 'es2022';
}

// The es6 is the same as es2015, compatible with rspack API schema
if (normalizedSyntaxItem === 'es6') {
return 'es2015';
}
return normalizedSyntaxItem;
}

Expand Down
16 changes: 16 additions & 0 deletions packages/core/tests/syntax.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,13 +153,20 @@ describe('transformSyntaxToBrowserslist', () => {

describe('transformSyntaxToRspackTarget', () => {
test('esX', () => {
const es6 = transformSyntaxToRspackTarget('es6');
const es2023 = transformSyntaxToRspackTarget('es2023');
const es2024 = transformSyntaxToRspackTarget('es2024');
const esnext = transformSyntaxToRspackTarget('esnext');

expect(es2023).toEqual(es2024);
expect(es2023).toEqual(esnext);

expect(es6).toMatchInlineSnapshot(`
[
"es2015",
]
`);

expect(es2023).toMatchInlineSnapshot(
`
[
Expand All @@ -186,5 +193,14 @@ describe('transformSyntaxToRspackTarget', () => {
"es2022",
]
`);

expect(
transformSyntaxToRspackTarget(['Chrome 123', 'es6']),
).toMatchInlineSnapshot(`
[
"browserslist:Chrome 123",
"es2015",
]
`);
});
});
Loading