Skip to content

fix: use global as mf format external type #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 28, 2024
Merged

fix: use global as mf format external type #331

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
757cd3f
fix: use global as mf format external type
Oct 25, 2024
828abcd
chore: modify note
Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/core/src/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -656,7 +656,8 @@ const composeExternalsConfig = (
esm: 'module-import',
cjs: 'commonjs',
umd: 'umd',
mf: 'var', // same as default value
// if use 'var', when users use external package like '@pkg', this will cause syntax error like 'var pkg = @pkg'
mf: 'global',
} as const;

switch (format) {
Expand Down
Loading