feat: support lib.id #436
Merged
feat: support lib.id #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 5 out of 8 changed files in this pull request and generated no suggestions.
Files not reviewed (3)
- website/docs/en/config/lib/_meta.json: Language not supported
- website/docs/en/config/lib/id.mdx: Language not supported
- website/docs/en/guide/basic/cli.mdx: Language not supported
Comments skipped due to low confidence (1)
packages/core/src/config.ts:1314
- The error message for duplicated IDs could be more informative. Consider specifying which IDs are duplicated and suggesting how to resolve the conflict.
throw new Error('The following ids are duplicated: ${conflictIds.map((id) => `"${id}"`).join(', ')}. Please make sure each lib has a unique id.');
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Copilot reviewed 5 out of 8 changed files in this pull request and generated no suggestions.
Files not reviewed (3)
- website/docs/en/config/lib/_meta.json: Language not supported
- website/docs/en/config/lib/id.mdx: Language not supported
- website/docs/en/guide/basic/cli.mdx: Language not supported
CodSpeed Performance ReportMerging #436 will not alter performanceComparing Summary
|
Co-authored-by: Timeless0911 <[email protected]>
Co-authored-by: Timeless0911 <[email protected]>
Timeless0911
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Close #382.
Support configure
lib.idin userland.Related Links
Checklist