fix: the moduleIds should be deterministic if the env is production and format is mf #487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for rslib ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Member
|
Can we add this configuration here instead of another tools function? rslib/packages/core/src/config.ts Line 583 in 5c8a73b |
CodSpeed Performance ReportMerging #487 will not alter performanceComparing Summary
|
Timeless0911
previously approved these changes
Nov 28, 2024
2heal1
force-pushed
the
fix/mf-module-ids
branch
from
bf7c801 to
9a2ce7a
Compare
2heal1
force-pushed
the
fix/mf-module-ids
branch
from
9a2ce7a to
fce3871
Compare
nyqykk
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When format is mf , and env is production , the moduleIds should be deterministic for better cache and smaller size.
And the named moduleIds may cause domain name leaked if the build env path has sensitive infomation
Related Links
Checklist