Skip to content

Conversation

@fi3ework
Copy link
Member

Summary

  • Use import type for React when we're already using automatic jsx runtime
  • Use exclude in tsconfig.json to make the test files are also included and get correct type resolve.

Related Links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 25, 2024

CodSpeed Performance Report

Merging #607 will not alter performance

Comparing import-type (97b3a2f) with main (eb04736)

Summary

✅ 5 untouched benchmarks

@fi3ework fi3ework changed the title chore: prefer to use type import of React fix(create-rslib): remove unnecessary React import Dec 25, 2024
@netlify
Copy link

netlify bot commented Dec 25, 2024

Deploy Preview for rslib ready!

Name Link
🔨 Latest commit 6211cc3
🔍 Latest deploy log https://app.netlify.com/sites/rslib/deploys/676bcf44daa19700083ca112
😎 Deploy Preview https://deploy-preview-607--rslib.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fi3ework fi3ework marked this pull request as ready for review December 25, 2024 08:47
@fi3ework fi3ework merged commit fcbdfa5 into main Dec 25, 2024
16 checks passed
@fi3ework fi3ework deleted the import-type branch December 25, 2024 15:15
@Timeless0911 Timeless0911 mentioned this pull request Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants