feat: clear console before ready log #683
Conversation
| import { loadTsconfig } from './utils/tsconfig'; | ||
|
|
||
| rsbuildLogger.override({ | ||
| start: (message) => { |
There was a problem hiding this comment.
Overriding logger.start is not a good idea, how about using a hook like onBeforeBuild
There was a problem hiding this comment.
We cannot guarantee that logger.start will not be called from somewhere else
There was a problem hiding this comment.
I tried onBeforeBuild before, but when multiple environments presents. It will be called multiple times. I think I should re-implement something like Building... with Rspack watchRun and done hook in Rslib side.
There was a problem hiding this comment.
onBeforeBuild is a global hook, are you registering plugins in global？
There was a problem hiding this comment.
onBeforeBuild is a global hook, are you registering plugins in global？
Yes. 🤡
There was a problem hiding this comment.
@chenjiahan 🤔 Does Rsbuild interest in embed this clear so Rslib can inherit? The usage are same. It's better to align with Rsbuild.
There was a problem hiding this comment.
Rsbuild will not clear the logs before rebuilding, as this will likely cause useful logs to be cleared and make troubleshooting more difficult.
There was a problem hiding this comment.
I'd like to give a try on Rslib, hoping it fit with the simpler lib scenario. 😀
There was a problem hiding this comment.
In fact, Rsbuild early versions will clear the log by default, but we later found that this caused more trouble than benefit, so we canceled it. However, for Rslib scenarios it is still worth a try.
There was a problem hiding this comment.
Can't find an elegant way to archive this, I'm heading to close for now.
onBeforeBuildwill run afterBuilding...and clear it, so it's not an option.watchRunis good, but can't find a way to register the plugin for only once. Register to the first environment only is also an ugly workaround.
Timeless0911
changed the title
Summary
Previously, Rslib's logs have continuously accumulated results from previous builds, which can make it challenging to observe the outcomes of the most recent builds, particularly when there were errors in earlier builds.
In this PR, soft clear on watch mode.
Before:
before.mp4
After:
after.mp4
Related Links
Checklist